MLK-20438 drm/bridge: sec-dsim: remove 'FORCEBTA' for packet send
authorFancy Fang <chen.fang@nxp.com>
Sat, 1 Dec 2018 09:08:20 +0000 (17:08 +0800)
committerLeonard Crestez <leonard.crestez@nxp.com>
Wed, 17 Apr 2019 23:51:34 +0000 (02:51 +0300)
Configure 'FORCEBTA' mandatorily for every packet send may
cause some packet send timeout in a low possibility. And
until now, this timeout issue only happens during panel
disable callback with the below error log:

"
imx_sec_dsim_drv 32e10000.mipi_dsi: wait pkthdr tx done time out
panel-raydium-rm67191 32e10000.mipi_dsi.0: [drm:rad_panel_disable] *ERROR* Failed to enter sleep mode (-16)
imx_sec_dsim_drv 32e10000.mipi_dsi: panel disable failed: -16
panel-raydium-rm67191 32e10000.mipi_dsi.0: [drm:rad_panel_unprepare] *ERROR* Panel still enabled!
imx_sec_dsim_drv 32e10000.mipi_dsi: panel unprepare failed: -1
"

The root cause for this error is not clear, but remove
'FORCEBTA' can avoid it and won't cause any side effect.

Signed-off-by: Fancy Fang <chen.fang@nxp.com>
(cherry picked from commit 811696087681cd45a8150afff7a8da3a2a6eb113)

drivers/gpu/drm/bridge/sec-dsim.c

index 902ac0e..2e8d4c1 100644 (file)
@@ -554,12 +554,6 @@ static void sec_mipi_dsim_config_cmd_lpm(struct sec_mipi_dsim *dsim,
        else
                escmode &= ~ESCMODE_CMDLPDT;
 
-       /* force BTA at the end of packet transfer
-        * to receive the acknowledgment from dsi
-        * peripheral for this transfer
-        */
-       escmode |= ESCMODE_FORCEBTA;
-
        dsim_write(dsim, escmode, DSIM_ESCMODE);
 }