LF-3715-1 net: phy: realtek: change "rtl821x,clkout_en" to "rtl821x,clkout-disable"
authorJoakim Zhang <qiangqing.zhang@nxp.com>
Thu, 27 May 2021 11:21:37 +0000 (19:21 +0800)
committerJason Liu <jason.hui.liu@nxp.com>
Fri, 28 May 2021 06:05:10 +0000 (14:05 +0800)
For PHY RTL8211FDI-CG, CLKOUT clock default is enabled by hardware, use
"rtl821x,clkout-disable" property to disable CLKOUT if user required. If
use "rtl821x,clkout_en" property to enable CLKOUT clock, it will block existing
cases which need this CLKOUT for MAC but doesn't add this property. It's
safe to change "rtl821x,clkout_en" to "rtl821x,clkout-disable", as to be
removed property("rtl821x,clkout_en") never been used in the kernel
tree.

Camelia Groza validated on LS1043ARDB.

Tested-by: Camelia Groza <camelia.groza@nxp.com>
Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
Reviewed-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Acked-by: Jason Liu <jason.hui.liu@nxp.com>
Documentation/devicetree/bindings/net/realtek.txt
drivers/net/phy/realtek.c

index c3e43f1..8cd83b0 100644 (file)
@@ -3,5 +3,5 @@ Realtek PHY properties.
 These properties cover the base properties Realtek PHYs.
 
 Optional properties:
- - rtl821x,clkout_en : enable clkout to supply clocks for MAC.
+ - rtl821x,clkout-disable: disable CLKOUT clock.
  - rtl821x,aldps-disable : disable ALDPS mode.
index 2276e1b..746cdfd 100644 (file)
@@ -93,7 +93,7 @@ static int rtl821x_probe(struct phy_device *phydev)
        if (!priv)
                return -ENOMEM;
 
-       if (of_property_read_bool(dev->of_node, "rtl821x,clkout_en"))
+       if (!of_property_read_bool(dev->of_node, "rtl821x,clkout-disable"))
                priv->quirks |= RTL821X_CLKOUT_EN_FEATURE;
 
        if (of_property_read_bool(dev->of_node, "rtl821x,aldps-disable"))