net/ipv6: use semicolons rather than commas to separate statements
authorJulia Lawall <Julia.Lawall@inria.fr>
Sun, 11 Oct 2020 10:34:57 +0000 (12:34 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 14 Oct 2020 00:11:52 +0000 (17:11 -0700)
Replace commas with semicolons.  Commas introduce unnecessary
variability in the code structure and are hard to see.  What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Acked-by: Paul Moore <paul@paul-moore.com>
Link: https://lore.kernel.org/r/1602412498-32025-5-git-send-email-Julia.Lawall@inria.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/calipso.c

index 8d3f66c..78f7660 100644 (file)
@@ -761,7 +761,7 @@ static int calipso_genopt(unsigned char *buf, u32 start, u32 buf_len,
        calipso[1] = len - 2;
        *(__be32 *)(calipso + 2) = htonl(doi_def->doi);
        calipso[6] = (len - CALIPSO_HDR_LEN) / 4;
-       calipso[7] = secattr->attr.mls.lvl,
+       calipso[7] = secattr->attr.mls.lvl;
        crc = ~crc_ccitt(0xffff, calipso, len);
        calipso[8] = crc & 0xff;
        calipso[9] = (crc >> 8) & 0xff;