soundwire: stream: fix support for multiple Slaves on the same link

The existing code will unconditionally return after dealing with the
first Slave on a link. This return should only happen when there is
an error case.

Tested on Comet Lake platform.

Signed-off-by: Rander Wang <rander.wang@intel.com>
Link: https://lore.kernel.org/r/20200114235227.14502-5-pierre-louis.bossart@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index c28ce7f..da10f38 100644 (file)
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -587,10 +587,11 @@ static int sdw_notify_config(struct sdw_master_runtime *m_rt)
 
                if (slave->ops->bus_config) {
                        ret = slave->ops->bus_config(slave, &bus->params);
-                       if (ret < 0)
+                       if (ret < 0) {
                                dev_err(bus->dev, "Notify Slave: %d failed\n",
                                        slave->dev_num);
-                       return ret;
+                               return ret;
+                       }
                }
        }