mt76: remove unnecessary annotations
authorJules Irenge <jbi.octave@gmail.com>
Sat, 11 Apr 2020 00:19:26 +0000 (01:19 +0100)
committerFelix Fietkau <nbd@nbd.name>
Tue, 12 May 2020 17:52:31 +0000 (19:52 +0200)
Sparse report warnings at mt76_tx_status_unlock() and mt76_tx_status_lock()

warning: context imbalance in mt76_tx_status_lock() - wrong count at exit
warning: context imbalance in mt76_tx_status_unlock() - unexpected unlock

The root cause is the additional __acquire(&dev->status_list.lock)
and __release(&dev->status_list.unlock) called
 from inside mt76_tx_status_lock() and mt76_tx_status_unlock().

Remove __acquire(&dev->status_list.lock) annotation
Remove __releases(&dev->status_list.unlock)
Correct &dev->status_list.unlock to &dev->status_list.lock
-unlock not defined in the sk_buff_head struct

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/tx.c

index eff522d..fca38ea 100644 (file)
@@ -101,19 +101,17 @@ mt76_tx_status_lock(struct mt76_dev *dev, struct sk_buff_head *list)
 {
        __skb_queue_head_init(list);
        spin_lock_bh(&dev->status_list.lock);
-       __acquire(&dev->status_list.lock);
 }
 EXPORT_SYMBOL_GPL(mt76_tx_status_lock);
 
 void
 mt76_tx_status_unlock(struct mt76_dev *dev, struct sk_buff_head *list)
-                     __releases(&dev->status_list.unlock)
+                     __releases(&dev->status_list.lock)
 {
        struct ieee80211_hw *hw;
        struct sk_buff *skb;
 
        spin_unlock_bh(&dev->status_list.lock);
-       __release(&dev->status_list.unlock);
 
        while ((skb = __skb_dequeue(list)) != NULL) {
                hw = mt76_tx_status_get_hw(dev, skb);