drm/edid: Fix uninitialized variable in drm_cvt_modes()
authorLyude Paul <lyude@redhat.com>
Thu, 5 Nov 2020 23:57:02 +0000 (18:57 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:53:03 +0000 (11:53 +0100)
[ Upstream commit 991fcb77f490390bcad89fa67d95763c58cdc04c ]

Noticed this when trying to compile with -Wall on a kernel fork. We
potentially don't set width here, which causes the compiler to complain
about width potentially being uninitialized in drm_cvt_modes(). So, let's
fix that.

Changes since v1:
* Don't emit an error as this code isn't reachable, just mark it as such
Changes since v2:
* Remove now unused variable

Fixes: 3f649ab728cd ("treewide: Remove uninitialized_var() usage")
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
Link: https://patchwork.freedesktop.org/patch/msgid/20201105235703.1328115-1-lyude@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/drm_edid.c

index 631125b..b84efd5 100644 (file)
@@ -3114,6 +3114,8 @@ static int drm_cvt_modes(struct drm_connector *connector,
                case 0x0c:
                        width = height * 15 / 9;
                        break;
+               default:
+                       unreachable();
                }
 
                for (j = 1; j < 5; j++) {