ARM: dts: msm8660: Fix up GIC IRQ flags
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 29 Nov 2018 11:08:21 +0000 (12:08 +0100)
committerAndy Gross <andy.gross@linaro.org>
Tue, 22 Jan 2019 21:04:48 +0000 (15:04 -0600)
All the GSBI blocks are marking their GIC IRQ lines as
"IRQ_TYPE_NONE" but there is no such thing: all GIC IRQ
lines have a trigger type.

That yields the following warning from the GIC driver:

WARNING: CPU: 0 PID: 1 at ../drivers/irqchip/irq-gic.c:1016
 gic_irq_domain_translate+0xdc/0xe4
(...)

Mark all of these IRQ_TYPE_LEVEL_HIGH as is common so this
warning goes away.

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
arch/arm/boot/dts/qcom-msm8660.dtsi

index 9b1cf00..e5da870 100644 (file)
                                compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm";
                                reg = <0x16540000 0x1000>,
                                      <0x16500000 0x1000>;
-                               interrupts = <GIC_SPI 156 IRQ_TYPE_NONE>;
+                               interrupts = <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>;
                                clocks = <&gcc GSBI6_UART_CLK>, <&gcc GSBI6_H_CLK>;
                                clock-names = "core", "iface";
                                status = "disabled";
                        gsbi6_i2c: i2c@16580000 {
                                compatible = "qcom,i2c-qup-v1.1.1";
                                reg = <0x16580000 0x1000>;
-                               interrupts = <GIC_SPI 157 IRQ_TYPE_NONE>;
+                               interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;
                                clocks = <&gcc GSBI6_QUP_CLK>, <&gcc GSBI6_H_CLK>;
                                clock-names = "core", "iface";
                                #address-cells = <1>;
                                compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm";
                                reg = <0x16640000 0x1000>,
                                      <0x16600000 0x1000>;
-                               interrupts = <GIC_SPI 158 IRQ_TYPE_NONE>;
+                               interrupts = <GIC_SPI 158 IRQ_TYPE_LEVEL_HIGH>;
                                clocks = <&gcc GSBI7_UART_CLK>, <&gcc GSBI7_H_CLK>;
                                clock-names = "core", "iface";
                                status = "disabled";
                        gsbi7_i2c: i2c@16680000 {
                                compatible = "qcom,i2c-qup-v1.1.1";
                                reg = <0x16680000 0x1000>;
-                               interrupts = <GIC_SPI 159 IRQ_TYPE_NONE>;
+                               interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
                                clocks = <&gcc GSBI7_QUP_CLK>, <&gcc GSBI7_H_CLK>;
                                clock-names = "core", "iface";
                                #address-cells = <1>;
                        gsbi8_i2c: i2c@19880000 {
                                compatible = "qcom,i2c-qup-v1.1.1";
                                reg = <0x19880000 0x1000>;
-                               interrupts = <GIC_SPI 161 IRQ_TYPE_NONE>;
+                               interrupts = <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>;
                                clocks = <&gcc GSBI8_QUP_CLK>, <&gcc GSBI8_H_CLK>;
                                clock-names = "core", "iface";
                                #address-cells = <1>;
                                compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm";
                                reg = <0x19c40000 0x1000>,
                                      <0x19c00000 0x1000>;
-                               interrupts = <0 195 IRQ_TYPE_NONE>;
+                               interrupts = <0 195 IRQ_TYPE_LEVEL_HIGH>;
                                clocks = <&gcc GSBI12_UART_CLK>, <&gcc GSBI12_H_CLK>;
                                clock-names = "core", "iface";
                                status = "disabled";
                        gsbi12_i2c: i2c@19c80000 {
                                compatible = "qcom,i2c-qup-v1.1.1";
                                reg = <0x19c80000 0x1000>;
-                               interrupts = <0 196 IRQ_TYPE_NONE>;
+                               interrupts = <0 196 IRQ_TYPE_LEVEL_HIGH>;
                                clocks = <&gcc GSBI12_QUP_CLK>, <&gcc GSBI12_H_CLK>;
                                clock-names = "core", "iface";
                                #address-cells = <1>;