ib_srp: Remove WARN_ON in srp_terminate_io()

The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE
at that time, so no new commands can be submitted via srp_queuecommand()

Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.com>
Acked-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>

diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index 36ade9a..eed0eb3 100644 (file)
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -1330,17 +1330,8 @@ static void srp_terminate_io(struct srp_rport *rport)
 {
        struct srp_target_port *target = rport->lld_data;
        struct srp_rdma_ch *ch;
-       struct Scsi_Host *shost = target->scsi_host;
-       struct scsi_device *sdev;
        int i, j;
 
-       /*
-        * Invoking srp_terminate_io() while srp_queuecommand() is running
-        * is not safe. Hence the warning statement below.
-        */
-       shost_for_each_device(sdev, shost)
-               WARN_ON_ONCE(sdev->request_queue->request_fn_active);
-
        for (i = 0; i < target->ch_count; i++) {
                ch = &target->ch[i];