pwm: sifive: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 14:47:45 +0000 (16:47 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Thu, 24 Sep 2020 07:18:11 +0000 (09:18 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-sifive.c

index 62de0bb..2485fba 100644 (file)
@@ -254,11 +254,9 @@ static int pwm_sifive_probe(struct platform_device *pdev)
                return PTR_ERR(ddata->regs);
 
        ddata->clk = devm_clk_get(dev, NULL);
-       if (IS_ERR(ddata->clk)) {
-               if (PTR_ERR(ddata->clk) != -EPROBE_DEFER)
-                       dev_err(dev, "Unable to find controller clock\n");
-               return PTR_ERR(ddata->clk);
-       }
+       if (IS_ERR(ddata->clk))
+               return dev_err_probe(dev, PTR_ERR(ddata->clk),
+                                    "Unable to find controller clock\n");
 
        ret = clk_prepare_enable(ddata->clk);
        if (ret) {