projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8008342
)
bpf: Add missing newline characters in verifier error messages
author
Yonghong Song
<yhs@fb.com>
Tue, 28 Jul 2020 22:18:01 +0000
(15:18 -0700)
committer
Daniel Borkmann
<daniel@iogearbox.net>
Thu, 30 Jul 2020 22:43:49 +0000
(
00:43
+0200)
Newline characters are added in two verifier error messages,
refactored in Commit
afbf21dce668
("bpf: Support readonly/readwrite
buffers in verifier"). This way, they do not mix with
messages afterwards.
Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Song Liu <songliubraving@fb.com>
Link:
https://lore.kernel.org/bpf/20200728221801.1090349-1-yhs@fb.com
kernel/bpf/verifier.c
patch
|
blob
|
history
diff --git
a/kernel/bpf/verifier.c
b/kernel/bpf/verifier.c
index
88bb25d
..
b6ccfce
100644
(file)
--- a/
kernel/bpf/verifier.c
+++ b/
kernel/bpf/verifier.c
@@
-3069,7
+3069,7
@@
static int __check_buffer_access(struct bpf_verifier_env *env,
{
if (off < 0) {
verbose(env,
- "R%d invalid %s buffer access: off=%d, size=%d",
+ "R%d invalid %s buffer access: off=%d, size=%d
\n
",
regno, buf_info, off, size);
return -EACCES;
}
@@
-3078,7
+3078,7
@@
static int __check_buffer_access(struct bpf_verifier_env *env,
tnum_strn(tn_buf, sizeof(tn_buf), reg->var_off);
verbose(env,
- "R%d invalid variable buffer offset: off=%d, var_off=%s",
+ "R%d invalid variable buffer offset: off=%d, var_off=%s
\n
",
regno, off, tn_buf);
return -EACCES;
}