LF-2488 media: mxc_capture: Fix Coverity Issue:11024996 Unchecked return value

Add return value check for fb_set_var

Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: G.n. Zhou <guoniu.zhou@nxp.com>

diff --git a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
index 9e2a730..b9dae9b 100644 (file)
--- a/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
+++ b/drivers/media/platform/mxc/capture/ipu_fg_overlay_sdc.c
@@ -396,7 +396,9 @@ static int foreground_start(void *private)
        fbvar.vmode &= ~FB_VMODE_YWRAP;
        fbvar.accel_flags = FB_ACCEL_DOUBLE_FLAG;
        fbvar.activate |= FB_ACTIVATE_FORCE;
-       fb_set_var(fbi, &fbvar);
+       err = fb_set_var(fbi, &fbvar);
+       if (err)
+               printk(KERN_WARNING "fb_set_var err code %d\n", err);
 
        ipu_disp_set_window_pos(disp_ipu, MEM_FG_SYNC, cam->win.w.left,
                        cam->win.w.top);
@@ -489,7 +491,9 @@ static int foreground_stop(void *private)
        fbvar.accel_flags = FB_ACCEL_TRIPLE_FLAG;
        fbvar.nonstd = cam->fb_origin_std;
        fbvar.activate |= FB_ACTIVATE_FORCE;
-       fb_set_var(fbi, &fbvar);
+       err = fb_set_var(fbi, &fbvar);
+       if (err)
+               printk(KERN_WARNING "fb_set_var err code %d\n", err);
 
 #ifdef CONFIG_MXC_MIPI_CSI2
        mipi_csi2_info = mipi_csi2_get_info();

diff --git a/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c b/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c
index e573f31..f15eea6 100644 (file)
--- a/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c
+++ b/drivers/media/platform/mxc/capture/ipu_prp_vf_sdc.c
@@ -127,7 +127,9 @@ static int prpvf_start(void *private)
        fbvar.yoffset = 0;
        fbvar.accel_flags = FB_ACCEL_DOUBLE_FLAG;
        fbvar.activate |= FB_ACTIVATE_FORCE;
-       fb_set_var(fbi, &fbvar);
+       err = fb_set_var(fbi, &fbvar);
+       if (err)
+               printk(KERN_WARNING "fb_set_var err code %d\n", err);
 
        ipu_disp_set_window_pos(disp_ipu, MEM_FG_SYNC, cam->win.w.left,
                        cam->win.w.top);
@@ -434,7 +436,9 @@ static int prpvf_stop(void *private)
        fbvar.accel_flags = FB_ACCEL_TRIPLE_FLAG;
        fbvar.nonstd = cam->fb_origin_std;
        fbvar.activate |= FB_ACTIVATE_FORCE;
-       fb_set_var(fbi, &fbvar);
+       err = fb_set_var(fbi, &fbvar);
+       if (err)
+               printk(KERN_WARNING "fb_set_var err code %d\n", err);
 
 #ifdef CONFIG_MXC_MIPI_CSI2
        mipi_csi2_info = mipi_csi2_get_info();