projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d7c0d92
)
libnvdimm/btt: fix variable 'rc' set but not used
author
Qian Cai
<cai@lca.pw>
Thu, 31 Oct 2019 14:05:19 +0000
(10:05 -0400)
committer
Dan Williams
<dan.j.williams@intel.com>
Sun, 17 Nov 2019 17:17:38 +0000
(09:17 -0800)
drivers/nvdimm/btt.c: In function 'btt_read_pg':
drivers/nvdimm/btt.c:1264:8: warning: variable 'rc' set but not used
[-Wunused-but-set-variable]
int rc;
^~
Add a ratelimited message in case a storm of errors is encountered.
Fixes:
d9b83c756953
("libnvdimm, btt: rework error clearing")
Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Link:
https://lore.kernel.org/r/1572530719-32161-1-git-send-email-cai@lca.pw
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/btt.c
patch
|
blob
|
history
diff --git
a/drivers/nvdimm/btt.c
b/drivers/nvdimm/btt.c
index
8cb890a
..
0d04ea3
100644
(file)
--- a/
drivers/nvdimm/btt.c
+++ b/
drivers/nvdimm/btt.c
@@
-1261,11
+1261,11
@@
static int btt_read_pg(struct btt *btt, struct bio_integrity_payload *bip,
ret = btt_data_read(arena, page, off, postmap, cur_len);
if (ret) {
- int rc;
-
/* Media error - set the e_flag */
- rc = btt_map_write(arena, premap, postmap, 0, 1,
- NVDIMM_IO_ATOMIC);
+ if (btt_map_write(arena, premap, postmap, 0, 1, NVDIMM_IO_ATOMIC))
+ dev_warn_ratelimited(to_dev(arena),
+ "Error persistently tracking bad blocks at %#x\n",
+ premap);
goto out_rtt;
}