cgroup: remove unnecessary unlikely()
authorYangtao Li <tiny.windzz@gmail.com>
Sun, 4 Nov 2018 02:27:41 +0000 (22:27 -0400)
committerTejun Heo <tj@kernel.org>
Mon, 5 Nov 2018 16:28:11 +0000 (08:28 -0800)
WARN_ON() already contains an unlikely(), so it's not necessary to use
unlikely.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup/cgroup.c

index 6aaf5dd..2e5d90d 100644 (file)
@@ -5978,10 +5978,8 @@ static ssize_t show_delegatable_files(struct cftype *files, char *buf,
 
                ret += snprintf(buf + ret, size - ret, "%s\n", cft->name);
 
-               if (unlikely(ret >= size)) {
-                       WARN_ON(1);
+               if (WARN_ON(ret >= size))
                        break;
-               }
        }
 
        return ret;