MLK-20235 mmc: sdhci-of-esdhc: fix coverity uncheck return value issue.
authorHaibo Chen <haibo.chen@nxp.com>
Mon, 19 Nov 2018 08:31:49 +0000 (16:31 +0800)
committerLeonard Crestez <leonard.crestez@nxp.com>
Thu, 2 May 2019 08:35:27 +0000 (11:35 +0300)
CID 4058489: Unchecked return value (CHECKED_RETURN)
2. check_return: Calling dma_set_mask_and_coherent without checking
return value.

Signed-off-by: Arulpandiyan Vadivel <arulpandiyan_vadivel@mentor.com>
Signed-off-by: Shrikant Bobade <Shrikant_Bobade@mentor.com>
(cherry picked from commit 9df9165707c34b8c4efe0e89f97e93cca7a222a0)

drivers/mmc/host/sdhci-of-esdhc.c

index a7bf851..8d4061b 100644 (file)
@@ -473,11 +473,17 @@ static void esdhc_of_adma_workaround(struct sdhci_host *host, u32 intmask)
 static int esdhc_of_enable_dma(struct sdhci_host *host)
 {
        u32 value;
+       int ret;
        struct device *dev = mmc_dev(host->mmc);
 
        if (of_device_is_compatible(dev->of_node, "fsl,ls1043a-esdhc") ||
-           of_device_is_compatible(dev->of_node, "fsl,ls1046a-esdhc"))
-               dma_set_mask_and_coherent(dev, DMA_BIT_MASK(40));
+           of_device_is_compatible(dev->of_node, "fsl,ls1046a-esdhc")) {
+               ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(40));
+               if (ret) {
+                       pr_warn("%s: Failed to set 40-bit DMA mask.\n",
+                               mmc_hostname(host->mmc));
+               }
+       }
 
        value = sdhci_readl(host, ESDHC_DMA_SYSCTL);
        value |= ESDHC_DMA_SNOOP;