crypto: seqiv - remove seqiv_create()
authorEric Biggers <ebiggers@google.com>
Fri, 10 Jul 2020 06:20:37 +0000 (23:20 -0700)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 16 Jul 2020 11:49:08 +0000 (21:49 +1000)
seqiv_create() is pointless because it just checks that the template is
being instantiated as an AEAD, then calls seqiv_aead_create().  But
seqiv_aead_create() does the exact same check, via aead_geniv_alloc().

Just remove seqiv_create() and use seqiv_aead_create() directly.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/seqiv.c

index e48f875..23e22d8 100644 (file)
@@ -164,23 +164,9 @@ free_inst:
        return err;
 }
 
-static int seqiv_create(struct crypto_template *tmpl, struct rtattr **tb)
-{
-       struct crypto_attr_type *algt;
-
-       algt = crypto_get_attr_type(tb);
-       if (IS_ERR(algt))
-               return PTR_ERR(algt);
-
-       if ((algt->type ^ CRYPTO_ALG_TYPE_AEAD) & CRYPTO_ALG_TYPE_MASK)
-               return -EINVAL;
-
-       return seqiv_aead_create(tmpl, tb);
-}
-
 static struct crypto_template seqiv_tmpl = {
        .name = "seqiv",
-       .create = seqiv_create,
+       .create = seqiv_aead_create,
        .module = THIS_MODULE,
 };