projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
150a9c1
)
usb: chipidea: ci_hdrc_imx: add missing put_device() call in usbmisc_get_init_data()
author
Yu Kuai
<yukuai3@huawei.com>
Tue, 17 Nov 2020 01:14:30 +0000
(09:14 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Tue, 12 Jan 2021 19:18:19 +0000
(20:18 +0100)
commit
83a43ff80a566de8718dfc6565545a0080ec1fb5
upstream.
if of_find_device_by_node() succeed, usbmisc_get_init_data() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.
Fixes:
ef12da914ed6
("usb: chipidea: imx: properly check for usbmisc")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Cc: stable <stable@vger.kernel.org>
Link:
https://lore.kernel.org/r/20201117011430.642589-1-yukuai3@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/chipidea/ci_hdrc_imx.c
patch
|
blob
|
history
diff --git
a/drivers/usb/chipidea/ci_hdrc_imx.c
b/drivers/usb/chipidea/ci_hdrc_imx.c
index
5e07a0a
..
ee565bd
100644
(file)
--- a/
drivers/usb/chipidea/ci_hdrc_imx.c
+++ b/
drivers/usb/chipidea/ci_hdrc_imx.c
@@
-139,9
+139,13
@@
static struct imx_usbmisc_data *usbmisc_get_init_data(struct device *dev)
misc_pdev = of_find_device_by_node(args.np);
of_node_put(args.np);
- if (!misc_pdev
|| !platform_get_drvdata(misc_pdev)
)
+ if (!misc_pdev)
return ERR_PTR(-EPROBE_DEFER);
+ if (!platform_get_drvdata(misc_pdev)) {
+ put_device(&misc_pdev->dev);
+ return ERR_PTR(-EPROBE_DEFER);
+ }
data->dev = &misc_pdev->dev;
/*