[media] tveeprom: get rid of unused arg on tveeprom_hauppauge_analog()
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 3 Mar 2017 10:28:29 +0000 (07:28 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 3 Mar 2017 10:35:02 +0000 (07:35 -0300)
tveeprom_hauppauge_analog() used to need the I2C adapter in
order to print debug messages. As it now uses pr_foo() facilities
since commit 6037b3ca28f4 ("[media] tveeprom: print log messages
using pr_foo()"), the first argument of the function is not
needed anymore.

So, get rid of it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
14 files changed:
drivers/media/common/tveeprom.c
drivers/media/pci/bt8xx/bttv-cards.c
drivers/media/pci/cx18/cx18-driver.c
drivers/media/pci/cx23885/cx23885-cards.c
drivers/media/pci/cx88/cx88-cards.c
drivers/media/pci/ivtv/ivtv-driver.c
drivers/media/pci/saa7134/saa7134-cards.c
drivers/media/pci/saa7164/saa7164-cards.c
drivers/media/usb/au0828/au0828-cards.c
drivers/media/usb/cx231xx/cx231xx-cards.c
drivers/media/usb/dvb-usb-v2/mxl111sf.c
drivers/media/usb/em28xx/em28xx-cards.c
drivers/media/usb/pvrusb2/pvrusb2-eeprom.c
include/media/tveeprom.h

index 6e10202..ccf2d3b 100644 (file)
@@ -420,8 +420,8 @@ static int hasRadioTuner(int tunerType)
        return 0;
 }
 
-void tveeprom_hauppauge_analog(struct i2c_client *c, struct tveeprom *tvee,
-                               unsigned char *eeprom_data)
+void tveeprom_hauppauge_analog(struct tveeprom *tvee,
+                              unsigned char *eeprom_data)
 {
        /* ----------------------------------------------
        ** The hauppauge eeprom format is tagged
index a1b0f31..5cc42b4 100644 (file)
@@ -3717,7 +3717,7 @@ static void hauppauge_eeprom(struct bttv *btv)
 {
        struct tveeprom tv;
 
-       tveeprom_hauppauge_analog(&btv->i2c_client, &tv, eeprom_data);
+       tveeprom_hauppauge_analog(&tv, eeprom_data);
        btv->tuner_type = tv.tuner_type;
        btv->has_radio  = tv.has_radio;
 
index 206db81..8bce49c 100644 (file)
@@ -339,7 +339,7 @@ void cx18_read_eeprom(struct cx18 *cx, struct tveeprom *tv)
        case CX18_CARD_HVR_1600_ESMT:
        case CX18_CARD_HVR_1600_SAMSUNG:
        case CX18_CARD_HVR_1600_S5H1411:
-               tveeprom_hauppauge_analog(c, tv, eedata);
+               tveeprom_hauppauge_analog(tv, eedata);
                break;
        case CX18_CARD_YUAN_MPC718:
        case CX18_CARD_GOTVIEW_PCI_DVD3:
index 0350f13..9e39aea 100644 (file)
@@ -1143,8 +1143,7 @@ static void hauppauge_eeprom(struct cx23885_dev *dev, u8 *eeprom_data)
 {
        struct tveeprom tv;
 
-       tveeprom_hauppauge_analog(&dev->i2c_bus[0].i2c_client, &tv,
-               eeprom_data);
+       tveeprom_hauppauge_analog(&tv, eeprom_data);
 
        /* Make sure we support the board model */
        switch (tv.model) {
index cdfbde2..61e1803 100644 (file)
@@ -2854,7 +2854,7 @@ static void hauppauge_eeprom(struct cx88_core *core, u8 *eeprom_data)
 {
        struct tveeprom tv;
 
-       tveeprom_hauppauge_analog(&core->i2c_client, &tv, eeprom_data);
+       tveeprom_hauppauge_analog(&tv, eeprom_data);
        core->board.tuner_type = tv.tuner_type;
        core->tuner_formats = tv.tuner_formats;
        core->board.radio.type = tv.has_radio ? CX88_RADIO : 0;
index ab2ae53..aaccc11 100644 (file)
@@ -408,7 +408,7 @@ void ivtv_read_eeprom(struct ivtv *itv, struct tveeprom *tv)
 
        itv->i2c_client.addr = 0xA0 >> 1;
        tveeprom_read(&itv->i2c_client, eedata, sizeof(eedata));
-       tveeprom_hauppauge_analog(&itv->i2c_client, tv, eedata);
+       tveeprom_hauppauge_analog(tv, eedata);
 }
 
 static void ivtv_process_eeprom(struct ivtv *itv)
index 3212538..f79380f 100644 (file)
@@ -7319,7 +7319,7 @@ static void hauppauge_eeprom(struct saa7134_dev *dev, u8 *eeprom_data)
 {
        struct tveeprom tv;
 
-       tveeprom_hauppauge_analog(&dev->i2c_client, &tv, eeprom_data);
+       tveeprom_hauppauge_analog(&tv, eeprom_data);
 
        /* Make sure we support the board model */
        switch (tv.model) {
index 0e1cd7e..3af1606 100644 (file)
@@ -780,9 +780,7 @@ static void hauppauge_eeprom(struct saa7164_dev *dev, u8 *eeprom_data)
 {
        struct tveeprom tv;
 
-       /* TODO: Assumption: eeprom on bus 0 */
-       tveeprom_hauppauge_analog(&dev->i2c_bus[0].i2c_client, &tv,
-               eeprom_data);
+       tveeprom_hauppauge_analog(&tv, eeprom_data);
 
        /* Make sure we support the board model */
        switch (tv.model) {
index 313f659..43bfa77 100644 (file)
@@ -153,7 +153,7 @@ static void hauppauge_eeprom(struct au0828_dev *dev, u8 *eeprom_data)
 {
        struct tveeprom tv;
 
-       tveeprom_hauppauge_analog(&dev->i2c_client, &tv, eeprom_data);
+       tveeprom_hauppauge_analog(&tv, eeprom_data);
        dev->board.tuner_type = tv.tuner_type;
 
        /* Make sure we support the board model */
index f730fdb..9b28d57 100644 (file)
@@ -1165,8 +1165,7 @@ void cx231xx_card_setup(struct cx231xx *dev)
                        e->client.addr = 0xa0 >> 1;
 
                        read_eeprom(dev, &e->client, e->eeprom, sizeof(e->eeprom));
-                       tveeprom_hauppauge_analog(&e->client,
-                                               &e->tvee, e->eeprom + 0xc0);
+                       tveeprom_hauppauge_analog(&e->tvee, e->eeprom + 0xc0);
                        kfree(e);
                        break;
                }
index 60bc5cc..abf69d8 100644 (file)
@@ -938,8 +938,8 @@ static int mxl111sf_init(struct dvb_usb_device *d)
        ret = i2c_transfer(&d->i2c_adap, msg, 2);
        if (mxl_fail(ret))
                return 0;
-       tveeprom_hauppauge_analog(NULL, &state->tv, (0x84 == eeprom[0xa0]) ?
-                       eeprom + 0xa0 : eeprom + 0x80);
+       tveeprom_hauppauge_analog(&state->tv, (0x84 == eeprom[0xa0]) ?
+                                 eeprom + 0xa0 : eeprom + 0x80);
 #if 0
        switch (state->tv.model) {
        case 117001:
index 5f90d08..5f80a1b 100644 (file)
@@ -2974,8 +2974,7 @@ static void em28xx_card_setup(struct em28xx *dev)
 #endif
                /* Call first TVeeprom */
 
-               dev->i2c_client[dev->def_i2c_bus].addr = 0xa0 >> 1;
-               tveeprom_hauppauge_analog(&dev->i2c_client[dev->def_i2c_bus], &tv, dev->eedata);
+               tveeprom_hauppauge_analog(&tv, dev->eedata);
 
                dev->tuner_type = tv.tuner_type;
 
index 7252f11..8b643d5 100644 (file)
@@ -121,7 +121,7 @@ int pvr2_eeprom_analyze(struct pvr2_hdw *hdw)
        if (!eeprom)
                return -EINVAL;
 
-       tveeprom_hauppauge_analog(NULL, &tvdata, eeprom);
+       tveeprom_hauppauge_analog(&tvdata, eeprom);
 
        trace_eeprom("eeprom assumed v4l tveeprom module");
        trace_eeprom("eeprom direct call results:");
index c56501e..5324c82 100644 (file)
@@ -100,7 +100,7 @@ struct tveeprom {
  *                     contain 256 bytes filled with the contents of the
  *                     eeprom read from the Hauppauge device.
  */
-void tveeprom_hauppauge_analog(struct i2c_client *c, struct tveeprom *tvee,
+void tveeprom_hauppauge_analog(struct tveeprom *tvee,
                               unsigned char *eeprom_data);
 
 /**