nvme: avoid double dereference to convert le to cpu
authorMax Gurtovoy <maxg@mellanox.com>
Mon, 25 Feb 2019 11:00:04 +0000 (13:00 +0200)
committerChristoph Hellwig <hch@lst.de>
Fri, 5 Apr 2019 06:07:56 +0000 (08:07 +0200)
Use le16_to_cpu instead of le16_to_cpup and le64_to_cpu instead of
le64_to_cpup. This will also align the code to nvme-core driver
convention.

Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c

index 4706019..b593911 100644 (file)
@@ -1588,7 +1588,7 @@ static bool nvme_ns_ids_equal(struct nvme_ns_ids *a, struct nvme_ns_ids *b)
 static void nvme_update_disk_info(struct gendisk *disk,
                struct nvme_ns *ns, struct nvme_id_ns *id)
 {
-       sector_t capacity = le64_to_cpup(&id->nsze) << (ns->lba_shift - 9);
+       sector_t capacity = le64_to_cpu(id->nsze) << (ns->lba_shift - 9);
        unsigned short bs = 1 << ns->lba_shift;
 
        blk_mq_freeze_queue(disk->queue);
@@ -2549,7 +2549,7 @@ int nvme_init_identify(struct nvme_ctrl *ctrl)
        ctrl->crdt[2] = le16_to_cpu(id->crdt3);
 
        ctrl->oacs = le16_to_cpu(id->oacs);
-       ctrl->oncs = le16_to_cpup(&id->oncs);
+       ctrl->oncs = le16_to_cpu(id->oncs);
        ctrl->oaes = le32_to_cpu(id->oaes);
        atomic_set(&ctrl->abort_limit, id->acl + 1);
        ctrl->vwc = id->vwc;