MLK-21493 brcmfmac: move .brcmf_bus_preinit() after changing bus state
authorFugang Duan <fugang.duan@nxp.com>
Thu, 18 Apr 2019 08:21:20 +0000 (16:21 +0800)
committerFugang Duan <fugang.duan@nxp.com>
Thu, 18 Apr 2019 09:08:13 +0000 (17:08 +0800)
Moving the brcmf_bus_preinit() call allows the bus code to do some
required initialization before handling firmware control messages.

.brcmf_bus_preinit() already is called in .brcmf_bus_started() when
bus is ready. So remove it from .brcmf_c_preinit_dcmds().

Fixes: 383c26d2ea2f(MLK-18675-20 brcmfmac: Support wake on ping packet)
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c

index 5834168..de7e04c 100644 (file)
@@ -363,8 +363,6 @@ int brcmf_c_preinit_dcmds(struct brcmf_if *ifp)
        if (err)
                brcmf_info("Add unicast filter error (%d)\n", err);
 
-       /* do bus specific preinit here */
-       err = brcmf_bus_preinit(ifp->drvr->bus_if);
 done:
        return err;
 }