LF-3647 arm: imx: fix coverity scan error
authorFrank Li <Frank.Li@nxp.com>
Tue, 30 Mar 2021 17:12:42 +0000 (12:12 -0500)
committerFrank Li <Frank.Li@nxp.com>
Thu, 22 Apr 2021 19:59:15 +0000 (14:59 -0500)
of_match_device may return null
but of_id have not been checked in imx_mmdc_perf_init

pmu_mmdc->devtype_data = (struct fsl_mmdc_devtype_data *)of_id->data;

Signed-off-by: Frank Li <Frank.Li@nxp.com>
arch/arm/mach-imx/mmdc.c

index 8599936..1ca7d28 100644 (file)
@@ -103,7 +103,7 @@ struct mmdc_pmu {
        struct device *dev;
        struct perf_event *mmdc_events[MMDC_NUM_COUNTERS];
        struct hlist_node node;
-       struct fsl_mmdc_devtype_data *devtype_data;
+       const struct fsl_mmdc_devtype_data *devtype_data;
 };
 
 /*
@@ -501,7 +501,9 @@ static int imx_mmdc_perf_init(struct platform_device *pdev, void __iomem *mmdc_b
                name = devm_kasprintf(&pdev->dev,
                                GFP_KERNEL, "mmdc%d", mmdc_num);
 
-       pmu_mmdc->devtype_data = (struct fsl_mmdc_devtype_data *)of_id->data;
+       pmu_mmdc->devtype_data = &imx6q_data;
+       if (of_id)
+               pmu_mmdc->devtype_data = of_id->data;
 
        hrtimer_init(&pmu_mmdc->hrtimer, CLOCK_MONOTONIC,
                        HRTIMER_MODE_REL);