cifs: Fix to use kmem_cache_free() instead of kfree()
authorWei Yongjun <weiyongjun1@huawei.com>
Tue, 18 Dec 2018 06:37:02 +0000 (06:37 +0000)
committerSteve French <stfrench@microsoft.com>
Fri, 28 Dec 2018 16:09:46 +0000 (10:09 -0600)
memory allocated by kmem_cache_alloc() in alloc_cache_entry()
should be freed using kmem_cache_free(), not kfree().

Fixes: 34a44fb160f9 ("cifs: Add DFS cache routines")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
fs/cifs/dfs_cache.c

index d1e84bd..f4e0907 100644 (file)
@@ -413,7 +413,7 @@ alloc_cache_entry(const char *path, const struct dfs_info3_param *refs,
 
        ce->ce_path = kstrdup_const(path, GFP_KERNEL);
        if (!ce->ce_path) {
-               kfree(ce);
+               kmem_cache_free(dfs_cache_slab, ce);
                return ERR_PTR(-ENOMEM);
        }
        INIT_HLIST_NODE(&ce->ce_hlist);
@@ -422,7 +422,7 @@ alloc_cache_entry(const char *path, const struct dfs_info3_param *refs,
        rc = copy_ref_data(refs, numrefs, ce, NULL);
        if (rc) {
                kfree(ce->ce_path);
-               kfree(ce);
+               kmem_cache_free(dfs_cache_slab, ce);
                ce = ERR_PTR(rc);
        }
        return ce;