RDMA/bnxt_re: Remove unsupported modify_device callback

There is no need to return always zero for function which is not
supported.

Link: https://lore.kernel.org/r/20190923104158.5331-3-kamalheib1@gmail.com
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
index b4149dc..8afd7d9 100644 (file)
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
@@ -191,24 +191,6 @@ int bnxt_re_query_device(struct ib_device *ibdev,
        return 0;
 }
 
-int bnxt_re_modify_device(struct ib_device *ibdev,
-                         int device_modify_mask,
-                         struct ib_device_modify *device_modify)
-{
-       switch (device_modify_mask) {
-       case IB_DEVICE_MODIFY_SYS_IMAGE_GUID:
-               /* Modify the GUID requires the modification of the GID table */
-               /* GUID should be made as READ-ONLY */
-               break;
-       case IB_DEVICE_MODIFY_NODE_DESC:
-               /* Node Desc should be made as READ-ONLY */
-               break;
-       default:
-               break;
-       }
-       return 0;
-}
-
 /* Port */
 int bnxt_re_query_port(struct ib_device *ibdev, u8 port_num,
                       struct ib_port_attr *port_attr)

diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.h b/drivers/infiniband/hw/bnxt_re/ib_verbs.h
index 31662b1..23d972d 100644 (file)
--- a/drivers/infiniband/hw/bnxt_re/ib_verbs.h
+++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.h
@@ -145,9 +145,6 @@ struct bnxt_re_ucontext {
 int bnxt_re_query_device(struct ib_device *ibdev,
                         struct ib_device_attr *ib_attr,
                         struct ib_udata *udata);
-int bnxt_re_modify_device(struct ib_device *ibdev,
-                         int device_modify_mask,
-                         struct ib_device_modify *device_modify);
 int bnxt_re_query_port(struct ib_device *ibdev, u8 port_num,
                       struct ib_port_attr *port_attr);
 int bnxt_re_get_port_immutable(struct ib_device *ibdev, u8 port_num,

diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
index 30a54f8..7b914bd 100644 (file)
--- a/drivers/infiniband/hw/bnxt_re/main.c
+++ b/drivers/infiniband/hw/bnxt_re/main.c
@@ -625,7 +625,6 @@ static const struct ib_device_ops bnxt_re_dev_ops = {
        .map_mr_sg = bnxt_re_map_mr_sg,
        .mmap = bnxt_re_mmap,
        .modify_ah = bnxt_re_modify_ah,
-       .modify_device = bnxt_re_modify_device,
        .modify_qp = bnxt_re_modify_qp,
        .modify_srq = bnxt_re_modify_srq,
        .poll_cq = bnxt_re_poll_cq,