rtc: mpc5121: set range
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 6 Mar 2020 07:44:02 +0000 (08:44 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 16 Mar 2020 10:12:10 +0000 (11:12 +0100)
The datasheet states that 4052 is the maximum value for year. However, the
mpc5121 read_time and set_time function abuse the target time register
instead of using the broken down time so it is limited to 2106.

Link: https://lore.kernel.org/r/20200306074404.58909-3-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-mpc5121.c

index 845212f..5507f18 100644 (file)
@@ -352,6 +352,8 @@ static int mpc5121_rtc_probe(struct platform_device *op)
 
        rtc->rtc->ops = &mpc5200_rtc_ops;
        rtc->rtc->uie_unsupported = 1;
+       rtc->rtc->range_min = RTC_TIMESTAMP_BEGIN_0000;
+       rtc->rtc->range_max = 65733206399ULL; /* 4052-12-31 23:59:59 */
 
        if (of_device_is_compatible(op->dev.of_node, "fsl,mpc5121-rtc")) {
                u32 ka;
@@ -362,6 +364,13 @@ static int mpc5121_rtc_probe(struct platform_device *op)
                        out_be32(&rtc->regs->keep_alive, ka);
                }
                rtc->rtc->ops = &mpc5121_rtc_ops;
+               /*
+                * This is a limitation of the driver that abuses the target
+                * time register, the actual maximum year for the mpc5121 is
+                * also 4052.
+                */
+               rtc->rtc->range_min = 0;
+               rtc->rtc->range_max = U32_MAX;
        }
 
        err = rtc_register_device(rtc->rtc);