MLK-21585 Revert patch to re-add support for capturemode in s_parm
authorRobby Cai <robby.cai@nxp.com>
Fri, 26 Apr 2019 09:03:33 +0000 (17:03 +0800)
committerRobby Cai <robby.cai@nxp.com>
Fri, 26 Apr 2019 09:59:12 +0000 (17:59 +0800)
This reverts commit 8a7c5594c02022ca5fa7fb603e11b3e1feb76ed5.

capturemode is needed for legacy support, added it back.

Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: Guoniu.Zhou <guoniu.zhou@nxp.com>
drivers/media/v4l2-core/v4l2-ioctl.c

index 22d3e7a..cfe0a8c 100644 (file)
@@ -1988,22 +1988,7 @@ static int v4l_s_parm(const struct v4l2_ioctl_ops *ops,
        struct v4l2_streamparm *p = arg;
        int ret = check_fmt(file, p->type);
 
-       if (ret)
-               return ret;
-
-       /* Note: extendedmode is never used in drivers */
-       if (V4L2_TYPE_IS_OUTPUT(p->type)) {
-               memset(p->parm.output.reserved, 0,
-                      sizeof(p->parm.output.reserved));
-               p->parm.output.extendedmode = 0;
-               p->parm.output.outputmode &= V4L2_MODE_HIGHQUALITY;
-       } else {
-               memset(p->parm.capture.reserved, 0,
-                      sizeof(p->parm.capture.reserved));
-               p->parm.capture.extendedmode = 0;
-               p->parm.capture.capturemode &= V4L2_MODE_HIGHQUALITY;
-       }
-       return ops->vidioc_s_parm(file, fh, p);
+       return ret ? ret : ops->vidioc_s_parm(file, fh, p);
 }
 
 static int v4l_queryctrl(const struct v4l2_ioctl_ops *ops,