net: openvswitch: use new function dev_fetch_sw_netstats
authorHeiner Kallweit <hkallweit1@gmail.com>
Mon, 12 Oct 2020 08:19:12 +0000 (10:19 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 14 Oct 2020 00:33:49 +0000 (17:33 -0700)
Simplify the code by using new function dev_fetch_sw_netstats().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/5e52dc91-97b1-82b0-214b-65d404e4a2ec@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/openvswitch/vport-internal_dev.c

index d8fe66e..1e30d8d 100644 (file)
@@ -86,31 +86,13 @@ static void internal_dev_destructor(struct net_device *dev)
 static void
 internal_get_stats(struct net_device *dev, struct rtnl_link_stats64 *stats)
 {
-       int i;
-
        memset(stats, 0, sizeof(*stats));
        stats->rx_errors  = dev->stats.rx_errors;
        stats->tx_errors  = dev->stats.tx_errors;
        stats->tx_dropped = dev->stats.tx_dropped;
        stats->rx_dropped = dev->stats.rx_dropped;
 
-       for_each_possible_cpu(i) {
-               const struct pcpu_sw_netstats *percpu_stats;
-               struct pcpu_sw_netstats local_stats;
-               unsigned int start;
-
-               percpu_stats = per_cpu_ptr(dev->tstats, i);
-
-               do {
-                       start = u64_stats_fetch_begin_irq(&percpu_stats->syncp);
-                       local_stats = *percpu_stats;
-               } while (u64_stats_fetch_retry_irq(&percpu_stats->syncp, start));
-
-               stats->rx_bytes         += local_stats.rx_bytes;
-               stats->rx_packets       += local_stats.rx_packets;
-               stats->tx_bytes         += local_stats.tx_bytes;
-               stats->tx_packets       += local_stats.tx_packets;
-       }
+       dev_fetch_sw_netstats(stats, dev->tstats);
 }
 
 static const struct net_device_ops internal_dev_netdev_ops = {