drm/ttm: use swap macro in ttm_bo_handle_move_mem
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 9 Jul 2018 15:24:47 +0000 (10:24 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 10 Jul 2018 19:18:08 +0000 (14:18 -0500)
Make use of the swap macro and remove unnecessary variable *tmp_mem*.
This makes the code easier to read and maintain. Also, reduces the
stack usage.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/ttm/ttm_bo.c

index 5d8688e..5142dcb 100644 (file)
@@ -287,12 +287,9 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo,
 
        if (ret) {
                if (bdev->driver->move_notify) {
-                       struct ttm_mem_reg tmp_mem = *mem;
-                       *mem = bo->mem;
-                       bo->mem = tmp_mem;
+                       swap(*mem, bo->mem);
                        bdev->driver->move_notify(bo, false, mem);
-                       bo->mem = *mem;
-                       *mem = tmp_mem;
+                       swap(*mem, bo->mem);
                }
 
                goto out_err;