power: supply: ingenic: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 26 Aug 2020 14:48:57 +0000 (16:48 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 26 Aug 2020 15:25:42 +0000 (17:25 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/ingenic-battery.c

index dd3d93d..32dc77f 100644 (file)
@@ -147,11 +147,9 @@ static int ingenic_battery_probe(struct platform_device *pdev)
        psy_cfg.of_node = dev->of_node;
 
        bat->battery = devm_power_supply_register(dev, desc, &psy_cfg);
-       if (IS_ERR(bat->battery)) {
-               if (PTR_ERR(bat->battery) != -EPROBE_DEFER)
-                       dev_err(dev, "Unable to register battery\n");
-               return PTR_ERR(bat->battery);
-       }
+       if (IS_ERR(bat->battery))
+               return dev_err_probe(dev, PTR_ERR(bat->battery),
+                                    "Unable to register battery\n");
 
        ret = power_supply_get_battery_info(bat->battery, &bat->info);
        if (ret) {