optee: fix invalid of_node_put() in optee_driver_init()
authorJens Wiklander <jens.wiklander@linaro.org>
Mon, 9 Oct 2017 09:11:49 +0000 (11:11 +0200)
committerNitin Garg <nitin.garg@nxp.com>
Tue, 20 Mar 2018 19:53:25 +0000 (14:53 -0500)
The first node supplied to of_find_matching_node() has its reference
counter decreased as part of call to that function. In optee_driver_init()
after calling of_find_matching_node() it's invalid to call of_node_put() on
the supplied node again.

So remove the invalid call to of_node_put().

Reported-by: Alex Shi <alex.shi@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
(cherry picked from commit f044113113dd95ba73916bde10e804d3cdfa2662)

drivers/tee/optee/core.c

index b7492da..d0dd092 100644 (file)
@@ -587,7 +587,6 @@ static int __init optee_driver_init(void)
                return -ENODEV;
 
        np = of_find_matching_node(fw_np, optee_match);
-       of_node_put(fw_np);
        if (!np)
                return -ENODEV;