x86, apic: Remove smp_callin_clear_local_apic callback
authorDavid Rientjes <rientjes@google.com>
Thu, 31 Jul 2014 06:53:30 +0000 (23:53 -0700)
committerH. Peter Anvin <hpa@zytor.com>
Thu, 31 Jul 2014 15:05:41 +0000 (08:05 -0700)
Since commit b5660ba76b41 ("x86, platforms: Remove NUMAQ") removed NUMAQ,
the smp_callin_clear_local_apic() apic callback has been obsolete.
Remove it.

Signed-off-by: David Rientjes <rientjes@google.com>
Link: http://lkml.kernel.org/r/alpine.DEB.2.02.1407302349040.17503@chino.kir.corp.google.com
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
arch/x86/include/asm/apic.h
arch/x86/kernel/apic/apic_flat_64.c
arch/x86/kernel/apic/apic_noop.c
arch/x86/kernel/apic/apic_numachip.c
arch/x86/kernel/apic/bigsmp_32.c
arch/x86/kernel/apic/probe_32.c
arch/x86/kernel/apic/x2apic_cluster.c
arch/x86/kernel/apic/x2apic_phys.c
arch/x86/kernel/apic/x2apic_uv_x.c
arch/x86/kernel/smpboot.c

index 2201c26..b8c1380 100644 (file)
@@ -336,7 +336,6 @@ struct apic {
        int (*wakeup_secondary_cpu)(int apicid, unsigned long start_eip);
 
        bool wait_for_init_deassert;
-       void (*smp_callin_clear_local_apic)(void);
        void (*inquire_remote_apic)(int apicid);
 
        /* apic ops */
index 7d56b65..a790497 100644 (file)
@@ -197,7 +197,6 @@ static struct apic apic_flat =  {
        .send_IPI_self                  = apic_send_IPI_self,
 
        .wait_for_init_deassert         = false,
-       .smp_callin_clear_local_apic    = NULL,
        .inquire_remote_apic            = default_inquire_remote_apic,
 
        .read                           = native_apic_mem_read,
@@ -311,7 +310,6 @@ static struct apic apic_physflat =  {
        .send_IPI_self                  = apic_send_IPI_self,
 
        .wait_for_init_deassert         = false,
-       .smp_callin_clear_local_apic    = NULL,
        .inquire_remote_apic            = default_inquire_remote_apic,
 
        .read                           = native_apic_mem_read,
index c638efa..f05b4f0 100644 (file)
@@ -169,7 +169,6 @@ struct apic apic_noop = {
        .wakeup_secondary_cpu           = noop_wakeup_secondary_cpu,
 
        .wait_for_init_deassert         = false,
-       .smp_callin_clear_local_apic    = NULL,
        .inquire_remote_apic            = NULL,
 
        .read                           = noop_apic_read,
index c32f882..c0d9165 100644 (file)
@@ -247,7 +247,6 @@ static const struct apic apic_numachip __refconst = {
 
        .wakeup_secondary_cpu           = numachip_wakeup_secondary,
        .wait_for_init_deassert         = false,
-       .smp_callin_clear_local_apic    = NULL,
        .inquire_remote_apic            = NULL, /* REMRD not supported */
 
        .read                           = native_apic_mem_read,
index 74ffd3e..eb15916 100644 (file)
@@ -197,7 +197,6 @@ static struct apic apic_bigsmp = {
        .send_IPI_self                  = default_send_IPI_self,
 
        .wait_for_init_deassert         = true,
-       .smp_callin_clear_local_apic    = NULL,
        .inquire_remote_apic            = default_inquire_remote_apic,
 
        .read                           = native_apic_mem_read,
index 64248c7..5b617a9 100644 (file)
@@ -117,7 +117,6 @@ static struct apic apic_default = {
        .send_IPI_self                  = default_send_IPI_self,
 
        .wait_for_init_deassert         = true,
-       .smp_callin_clear_local_apic    = NULL,
        .inquire_remote_apic            = default_inquire_remote_apic,
 
        .read                           = native_apic_mem_read,
index 8b3200c..d96cab1 100644 (file)
@@ -278,7 +278,6 @@ static struct apic apic_x2apic_cluster = {
        .send_IPI_self                  = x2apic_send_IPI_self,
 
        .wait_for_init_deassert         = false,
-       .smp_callin_clear_local_apic    = NULL,
        .inquire_remote_apic            = NULL,
 
        .read                           = native_apic_msr_read,
index 14c1891..73d0fee 100644 (file)
@@ -132,7 +132,6 @@ static struct apic apic_x2apic_phys = {
        .send_IPI_self                  = x2apic_send_IPI_self,
 
        .wait_for_init_deassert         = false,
-       .smp_callin_clear_local_apic    = NULL,
        .inquire_remote_apic            = NULL,
 
        .read                           = native_apic_msr_read,
index 58f0988..cc5d40e 100644 (file)
@@ -395,7 +395,6 @@ static struct apic __refdata apic_x2apic_uv_x = {
 
        .wakeup_secondary_cpu           = uv_wakeup_secondary,
        .wait_for_init_deassert         = false,
-       .smp_callin_clear_local_apic    = NULL,
        .inquire_remote_apic            = NULL,
 
        .read                           = native_apic_msr_read,
index 5492798..f0f3b19 100644 (file)
@@ -168,10 +168,6 @@ static void smp_callin(void)
         * CPU, first the APIC. (this is probably redundant on most
         * boards)
         */
-
-       pr_debug("CALLIN, before setup_local_APIC()\n");
-       if (apic->smp_callin_clear_local_apic)
-               apic->smp_callin_clear_local_apic();
        setup_local_APIC();
        end_local_APIC_setup();