ASoC: sh: Replace 'select' DMADEVICES 'with depends on'
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Fri, 31 Jul 2020 15:24:32 +0000 (18:24 +0300)
committerMark Brown <broonie@kernel.org>
Fri, 31 Jul 2020 18:17:02 +0000 (19:17 +0100)
Enabling a whole subsystem from a single driver 'select' is frowned
upon and won't be accepted in new drivers, that need to use 'depends on'
instead. Existing selection of DMADEVICES will then cause circular
dependencies. Replace them with a dependency.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20200731152433.1297-3-laurent.pinchart@ideasonboard.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/Kconfig

index dc20f0f..ef8a29b 100644 (file)
@@ -30,8 +30,8 @@ config SND_SOC_SH4_FSI
 config SND_SOC_SH4_SIU
        tristate
        depends on ARCH_SHMOBILE && HAVE_CLK
+       depends on DMADEVICES
        select DMA_ENGINE
-       select DMADEVICES
        select SH_DMAE
        select FW_LOADER