tty: serial: fsl_lpuart: fix lpuart32_poll_get_char
authorPeng Fan <peng.fan@nxp.com>
Tue, 29 Sep 2020 09:55:09 +0000 (17:55 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Sep 2020 12:29:36 +0000 (14:29 +0200)
The watermark is set to 1, so we need to input two chars to trigger RDRF
using the original logic. With the new logic, we could always get the
char when there is data in FIFO.

Suggested-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20200929095509.21680-1-peng.fan@nxp.com
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/fsl_lpuart.c

index 645bbb2..590c901 100644 (file)
@@ -680,7 +680,7 @@ static void lpuart32_poll_put_char(struct uart_port *port, unsigned char c)
 
 static int lpuart32_poll_get_char(struct uart_port *port)
 {
-       if (!(lpuart32_read(port, UARTSTAT) & UARTSTAT_RDRF))
+       if (!(lpuart32_read(port, UARTWATER) >> UARTWATER_RXCNT_OFF))
                return NO_POLL_CHAR;
 
        return lpuart32_read(port, UARTDATA);