LF-2858 media: ipu: Fix Coverity Issue: 17676 Dereference before null check
authorRobby Cai <robby.cai@nxp.com>
Fri, 7 May 2021 09:42:42 +0000 (17:42 +0800)
committerRobby Cai <robby.cai@nxp.com>
Mon, 10 May 2021 03:45:26 +0000 (11:45 +0800)
Fix issue for dereference before NULL check

Signed-off-by: Robby Cai <robby.cai@nxp.com>
Reviewed-by: G.n. Zhou <guoniu.zhou@nxp.com>
drivers/media/platform/mxc/capture/ipu_prp_enc.c

index d1e1def..c26ef94 100644 (file)
@@ -63,7 +63,7 @@ static int prp_enc_setup(cam_data *cam)
 {
        ipu_channel_params_t enc;
        int err = 0;
-       dma_addr_t dummy = cam->dummy_frame.buffer.m.offset;
+       dma_addr_t dummy;
 #ifdef CONFIG_MXC_MIPI_CSI2
        void *mipi_csi2_info;
        int ipu_id;
@@ -75,6 +75,8 @@ static int prp_enc_setup(cam_data *cam)
                printk(KERN_ERR "cam private is NULL\n");
                return -ENXIO;
        }
+       dummy = cam->dummy_frame.buffer.m.offset;
+
        memset(&enc, 0, sizeof(ipu_channel_params_t));
 
        ipu_csi_get_window_size(cam->ipu, &enc.csi_prp_enc_mem.in_width,