MLK-15014 dma: fsl-edma-v3: clear DONE before E_SG enabled
authorRobin Gong <yibin.gong@nxp.com>
Tue, 6 Jun 2017 08:56:49 +0000 (16:56 +0800)
committerNitin Garg <nitin.garg@nxp.com>
Mon, 19 Mar 2018 20:22:34 +0000 (15:22 -0500)
Below described in RM, otherwise, channel error status(CHa_ES)
may be triggered:
The user must clear the CHa_CSR[DONE] bit before writing the
TCDa_CSR[MAJORELINK] or TCDa_CSR[ESG] bits.

Signed-off-by: Robin Gong <yibin.gong@nxp.com>
drivers/dma/fsl-edma-v3.c

index c20306c..f782849 100644 (file)
@@ -421,6 +421,11 @@ static void fsl_edma3_set_tcd_regs(struct fsl_edma3_chan *fsl_chan,
 
        writel(le32_to_cpu(tcd->dlast_sga), addr + EDMA_TCD_DLAST_SGA);
 
+       /* Must clear CHa_CSR[DONE] bit before enable TCDa_CSR[ESG] */
+       if ((EDMA_TCD_CSR_E_SG | le16_to_cpu(tcd->csr)) &&
+               EDMA_CH_CSR_DONE | readl(addr + EDMA_CH_CSR))
+               writel(EDMA_CH_CSR_DONE, addr + EDMA_CH_CSR);
+
        writew(le16_to_cpu(tcd->csr), addr + EDMA_TCD_CSR);
 }