nbd: fix 64-bit division
authorJens Axboe <axboe@fb.com>
Sat, 3 Dec 2016 19:08:03 +0000 (12:08 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Apr 2017 07:31:23 +0000 (09:31 +0200)
commit e88f72cb9f54f6d244e55f629fe5e2f34ca6f9ed upstream.

We have this:

ERROR: "__aeabi_ldivmod" [drivers/block/nbd.ko] undefined!
ERROR: "__divdi3" [drivers/block/nbd.ko] undefined!
nbd.c:(.text+0x247c72): undefined reference to `__divdi3'

due to a recent commit, that did 64-bit division. Use the proper
divider function so that 32-bit compiles don't break.

Fixes: ef77b515243b ("nbd: use loff_t for blocksize and nbd_set_size args")
Signed-off-by: Jens Axboe <axboe@fb.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/block/nbd.c

index 095b458..c9441f9 100644 (file)
@@ -648,7 +648,7 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
 
        case NBD_SET_SIZE:
                return nbd_size_set(nbd, bdev, nbd->blksize,
-                                   arg / nbd->blksize);
+                                       div_s64(arg, nbd->blksize));
 
        case NBD_SET_SIZE_BLOCKS:
                return nbd_size_set(nbd, bdev, nbd->blksize, arg);