MLK-18605-3 drm/bridge: sec-dsim: refuse unknown dsi device attach
authorFancy Fang <chen.fang@nxp.com>
Wed, 13 Jun 2018 11:01:39 +0000 (19:01 +0800)
committerLeonard Crestez <leonard.crestez@nxp.com>
Wed, 17 Apr 2019 23:51:34 +0000 (02:51 +0300)
When a dsi device who is neither a bridge nor a panel requests
to be attached to the host, refuse this request directly.

Signed-off-by: Fancy Fang <chen.fang@nxp.com>
(cherry picked from commit 2e80acc8a611327fcc77d2e73515bc062cdc4233)
(cherry picked from commit 9ef87498c5406b44cd41b9592bdec9c948c962d2)

drivers/gpu/drm/bridge/sec-dsim.c

index 2aead7d..e62b43c 100644 (file)
@@ -298,7 +298,12 @@ static int sec_mipi_dsim_host_attach(struct mipi_dsi_host *host,
        if (!dsim->next) {
                /* 'dsi' must be panel device */
                panel = of_drm_find_panel(dsi->dev.of_node);
-               WARN_ON(!panel);
+
+               if (!panel) {
+                       dev_err(dev, "refuse unknown dsi device attach\n");
+                       WARN_ON(!panel);
+                       return -ENODEV;
+               }
 
                /* Don't support multiple panels */
                if (dsim->panel && panel && dsim->panel != panel) {