rcu: Add READ_ONCE() to rcu_do_batch() access to rcu_cpu_stall_ftrace_dump
authorPaul E. McKenney <paulmck@kernel.org>
Wed, 24 Jun 2020 03:57:59 +0000 (20:57 -0700)
committerPaul E. McKenney <paulmck@kernel.org>
Tue, 25 Aug 2020 01:36:08 +0000 (18:36 -0700)
Given that sysfs can change the value of rcu_cpu_stall_ftrace_dump at any
time, this commit adds a READ_ONCE() to the accesses to that variable.

Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
kernel/rcu/tree_stall.h

index a1780a6..0fde39b 100644 (file)
@@ -623,7 +623,7 @@ static void check_cpu_stall(struct rcu_data *rdp)
 
                /* We haven't checked in, so go dump stack. */
                print_cpu_stall(gps);
-               if (rcu_cpu_stall_ftrace_dump)
+               if (READ_ONCE(rcu_cpu_stall_ftrace_dump))
                        rcu_ftrace_dump(DUMP_ALL);
 
        } else if (rcu_gp_in_progress() &&
@@ -632,7 +632,7 @@ static void check_cpu_stall(struct rcu_data *rdp)
 
                /* They had a few time units to dump stack, so complain. */
                print_other_cpu_stall(gs2, gps);
-               if (rcu_cpu_stall_ftrace_dump)
+               if (READ_ONCE(rcu_cpu_stall_ftrace_dump))
                        rcu_ftrace_dump(DUMP_ALL);
        }
 }