gpio: dwapb: Get rid of unnecessary conjunction over 32-bit value
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 22 Apr 2020 11:06:53 +0000 (14:06 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 28 Apr 2020 12:52:51 +0000 (14:52 +0200)
When we mask interrupts before sleep, there is no need to have a conjunction
with 0xffffffff since the accepted by dwapb_write() value is 32-bit.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Serge Semin <fancer.lancer@gmail.com>
Cc: Serge Semin <fancer.lancer@gmail.com>
Link: https://lore.kernel.org/r/20200422110654.23442-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-dwapb.c

index 31d29ec..9d8476a 100644 (file)
@@ -743,8 +743,7 @@ static int dwapb_gpio_suspend(struct device *dev)
                        ctx->int_deb    = dwapb_read(gpio, GPIO_PORTA_DEBOUNCE);
 
                        /* Mask out interrupts */
-                       dwapb_write(gpio, GPIO_INTMASK,
-                                   0xffffffff & ~ctx->wake_en);
+                       dwapb_write(gpio, GPIO_INTMASK, ~ctx->wake_en);
                }
        }
        spin_unlock_irqrestore(&gc->bgpio_lock, flags);