tracing: Clean up hist_field_flags enum
authorTom Zanussi <tom.zanussi@linux.intel.com>
Fri, 22 Sep 2017 19:58:21 +0000 (14:58 -0500)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 4 Oct 2017 17:06:56 +0000 (13:06 -0400)
As we add more flags, specifying explicit integers for the flag values
becomes more unwieldy and error-prone - switch them over to left-shift
values.

Link: http://lkml.kernel.org/r/e644e4fb7665aec015f4a2d84a2f990d3dd5b8a1.1506105045.git.tom.zanussi@linux.intel.com
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events_hist.c

index 121d568..0c7ec30 100644 (file)
@@ -110,16 +110,16 @@ DEFINE_HIST_FIELD_FN(u8);
 #define HIST_KEY_SIZE_MAX      (MAX_FILTER_STR_VAL + HIST_STACKTRACE_SIZE)
 
 enum hist_field_flags {
-       HIST_FIELD_FL_HITCOUNT          = 1,
-       HIST_FIELD_FL_KEY               = 2,
-       HIST_FIELD_FL_STRING            = 4,
-       HIST_FIELD_FL_HEX               = 8,
-       HIST_FIELD_FL_SYM               = 16,
-       HIST_FIELD_FL_SYM_OFFSET        = 32,
-       HIST_FIELD_FL_EXECNAME          = 64,
-       HIST_FIELD_FL_SYSCALL           = 128,
-       HIST_FIELD_FL_STACKTRACE        = 256,
-       HIST_FIELD_FL_LOG2              = 512,
+       HIST_FIELD_FL_HITCOUNT          = 1 << 0,
+       HIST_FIELD_FL_KEY               = 1 << 1,
+       HIST_FIELD_FL_STRING            = 1 << 2,
+       HIST_FIELD_FL_HEX               = 1 << 3,
+       HIST_FIELD_FL_SYM               = 1 << 4,
+       HIST_FIELD_FL_SYM_OFFSET        = 1 << 5,
+       HIST_FIELD_FL_EXECNAME          = 1 << 6,
+       HIST_FIELD_FL_SYSCALL           = 1 << 7,
+       HIST_FIELD_FL_STACKTRACE        = 1 << 8,
+       HIST_FIELD_FL_LOG2              = 1 << 9,
 };
 
 struct hist_trigger_attrs {