r8169: improve error message if no dedicated PHY driver is found
authorHeiner Kallweit <hkallweit1@gmail.com>
Mon, 27 Apr 2020 19:07:00 +0000 (21:07 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Apr 2020 20:25:13 +0000 (13:25 -0700)
There's a number of consumer mainboards where the BIOS leaves the PHY
in a state that it's reporting an invalid PHY ID. To detect such cases
add the PHY ID to the error message if no dedicated PHY driver is found.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index f70e36c..68d5255 100644 (file)
@@ -5197,7 +5197,8 @@ static int r8169_mdio_register(struct rtl8169_private *tp)
                /* Most chip versions fail with the genphy driver.
                 * Therefore ensure that the dedicated PHY driver is loaded.
                 */
-               dev_err(&pdev->dev, "realtek.ko not loaded, maybe it needs to be added to initramfs?\n");
+               dev_err(&pdev->dev, "no dedicated PHY driver found for PHY ID 0x%08x, maybe realtek.ko needs to be added to initramfs?\n",
+                       tp->phydev->phy_id);
                return -EUNATCH;
        }