net: ethernet: aquantia: Fix wrong return value
authorTianjia Zhang <tianjia.zhang@linux.alibaba.com>
Sun, 2 Aug 2020 11:15:37 +0000 (19:15 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Aug 2020 22:57:02 +0000 (15:57 -0700)
In function hw_atl_a0_hw_multicast_list_set(), when an invalid
request is encountered, a negative error code should be returned.

Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions")
Cc: David VomLehn <vomlehn@texas.net>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c

index c38a4b8..611875e 100644 (file)
@@ -786,7 +786,7 @@ static int hw_atl_a0_hw_multicast_list_set(struct aq_hw_s *self,
        int err = 0;
 
        if (count > (HW_ATL_A0_MAC_MAX - HW_ATL_A0_MAC_MIN)) {
-               err = EBADRQC;
+               err = -EBADRQC;
                goto err_exit;
        }
        for (cfg->mc_list_count = 0U; cfg->mc_list_count < count; ++cfg->mc_list_count) {