f2fs: protect new segment allocation in expand_inode_data
authorDaeho Jeong <daehojeong@google.com>
Wed, 27 May 2020 04:02:31 +0000 (13:02 +0900)
committerJaegeuk Kim <jaegeuk@kernel.org>
Thu, 28 May 2020 19:00:43 +0000 (12:00 -0700)
commitfd6126484ceaa9d94db196931c10454090f3d677
treecc4ccc4f2118cca281e3a745228cd917b5169f3a
parent195f406543e555611330b98ea8c21f113a192fc3
f2fs: protect new segment allocation in expand_inode_data

Found a new segemnt allocation without f2fs_lock_op() in
expand_inode_data(). So, when we do fallocate() for a pinned file
and trigger checkpoint very frequently and simultaneously. F2FS gets
stuck in the below code of do_checkpoint() forever.

  f2fs_sync_meta_pages(sbi, META, LONG_MAX, FS_CP_META_IO);
  /* Wait for all dirty meta pages to be submitted for IO */
                                                <= if fallocate() here,
  f2fs_wait_on_all_pages(sbi, F2FS_DIRTY_META); <= it'll wait forever.

Signed-off-by: Daeho Jeong <daehojeong@google.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c