soc: imx: gpc: Do not pass static memory as platform data
authorAndrey Smirnov <andrew.smirnov@gmail.com>
Tue, 10 Apr 2018 18:32:10 +0000 (11:32 -0700)
committerShawn Guo <shawnguo@kernel.org>
Mon, 23 Apr 2018 09:03:15 +0000 (17:03 +0800)
commitf54e714cfc53b9164d1206f9ee49042195532a51
tree7efea32f3af857ad9dde810873639a273f5324a5
parent050f810e238f268670f14a8f8b793ba2dbf2e92f
soc: imx: gpc: Do not pass static memory as platform data

Platform device core assumes the ownership of dev.platform_data as
well as that it is dynamically allocated and it will try to kfree it
as a part of platform_device_release(). Change the code to use
platform_device_add_data() instead of a pointer to a static memory to
avoid causing a BUG() when calling platform_device_put().

The problem can be reproduced by artificially enabling the error path
of platform_device_add() call (around line 452).

Cc: Stefan Agner <stefan@agner.ch>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
drivers/soc/imx/gpc.c