EDAC, sb_edac: Return early on ADDRV bit and address type test
authorQiuxu Zhuo <qiuxu.zhuo@intel.com>
Fri, 7 Sep 2018 23:08:27 +0000 (16:08 -0700)
committerBorislav Petkov <bp@suse.de>
Tue, 11 Sep 2018 08:59:21 +0000 (10:59 +0200)
commitdcc960b225ceb2bd66c45e0845d03e577f7010f9
tree8636004f069621da1ef8bdc89001ce31d7732ab6
parent528d132c86a1f4be68e431edb247dae58f278160
EDAC, sb_edac: Return early on ADDRV bit and address type test

Users of the mce_register_decode_chain() are called for every logged
error. EDAC drivers should check:

1) Is this a memory error? [bit 7 in status register]
2) Is there a valid address? [bit 58 in status register]
3) Is the address a system address? [bitfield 8:6 in misc register]

The sb_edac driver performed test "1" twice. Waited far too long to
perform check "2". Didn't do check "3" at all.

Fix it by moving the test for valid address from
sbridge_mce_output_error() into sbridge_mce_check_error() and add a test
for the type immediately after. Delete the redundant check for the type
of the error from sbridge_mce_output_error().

Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: Aristeu Rozanski <aris@redhat.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20180907230828.13901-2-tony.luck@intel.com
[ Re-word commit message. ]
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/sb_edac.c