MLK-20893: imx: in_le32 out_le32 preprocessor casting issue with addresses involving...
authorUtkarsh Gupta <utkarsh.gupta@nxp.com>
Mon, 25 Feb 2019 18:00:23 +0000 (12:00 -0600)
committerYe Li <ye.li@nxp.com>
Fri, 24 May 2019 11:28:19 +0000 (04:28 -0700)
commitd7b3da671ea09d7b0cf7fbf9077f3f0a28a8d4dd
treeafcfd95592dc42e7d420244238a2884ae1cf1e0e
parent6bf8976410982236d28cabb68b382f5e640fd79a
MLK-20893: imx: in_le32 out_le32 preprocessor casting issue with addresses involving math

The sec_in32 preprocessor is defined as follows in include/fsl_sec.h file:
When address "a" is calculated using math for ex: addition of base address and an offset, then casting is applied only to the first address which in this example is base address.

caam_ccbvid_reg = sec_in32(CONFIG_SYS_FSL_SEC_ADDR + CAAM_CCBVID_OFFSET)
resolves to:
caam_ccbvid_reg = in_le32((ulong *)(ulong)CONFIG_SYS_FSL_SEC_ADDR + CAAM_CCBVID_OFFSET)
instead it should resolve to:
caam_ccbvid_reg = in_le32((ulong *)(ulong)(CONFIG_SYS_FSL_SEC_ADDR + CAAM_CCBVID_OFFSET))

Thus add parenthesis around the address "a" so that however the address is calculated, the casting is applied to the final calculated address.

Bug introduced by commit 79e90af14af3 ("MLK-18044-2: crypto: caam: Fix build warnings pointer casting").

Signed-off-by: Utkarsh Gupta <utkarsh.gupta@nxp.com>
Reviewed-by: Horia Geanta <horia.geanta@nxp.com>
Reviewed-by: Ye Li <ye.li@nxp.com>
(cherry picked from commit 5d10d1cab052f8af4fd00640e09642aa0a596922)
include/fsl_sec.h