drm/savage: dereferencing an error pointer
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 12 Oct 2016 06:22:27 +0000 (09:22 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jan 2017 19:17:58 +0000 (20:17 +0100)
commitd65146c7fb91797d14edcd092a07d4432688f7d5
tree3df756a16c971d64c605ad7a0a6b846edc61e41d
parentc730a84aff6f3eca7dbe8b5e7bbc3cdd94418a54
drm/savage: dereferencing an error pointer

commit f7741aa75e76440f4e9ecfe512feebe9bce33ca8 upstream.

A recent cleanup changed the kmalloc() + copy_from_user() to
memdup_user() but the error handling wasn't updated so we might call
kfree(-EFAULT) and crash.

Fixes: a6e3918bcdb1 ('GPU-DRM-Savage: Use memdup_user() rather than duplicating')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20161012062227.GU12841@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/savage/savage_state.c