mwifiex: pcie: don't leak DMA buffers when removing
authorBrian Norris <briannorris@chromium.org>
Sat, 11 Mar 2017 01:39:21 +0000 (17:39 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Mar 2017 07:41:26 +0000 (09:41 +0200)
commitcb6e07ba5878959d5ebb6189e6e11cc335d914b6
tree385dcf91cadb69f2b9e71e89620e7d5b8f8e6a6e
parent35ef543eb372811d9090cbc4de0d5f86e6d2f787
mwifiex: pcie: don't leak DMA buffers when removing

commit 4e841d3eb9294ce4137fdb5d0a88f1bceab9c212 upstream.

When PCIe FLR support was added, much of the remove/release code for
PCIe was migrated to ->down_dev(), but ->down_dev() is never called for
device removal. Let's refactor the cleanup to be done in both cases.

Also, drop the comments above mwifiex_cleanup_pcie(), because they were
clearly wrong, and it's better to have clear and obvious code than to
detail the code steps in comments anyway.

Fixes: 4c5dae59d2e9 ("mwifiex: add PCIe function level reset support")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/marvell/mwifiex/pcie.c