staging: android: ashmem: fix a race condition in ASHMEM_SET_SIZE ioctl
authorViktor Slavkovic <viktors@google.com>
Mon, 8 Jan 2018 18:43:03 +0000 (10:43 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Jan 2018 08:38:56 +0000 (09:38 +0100)
commitc51d23dffc2e9ca05d611c86c440f9055541c62d
tree405a27d25ac6548b386dd056837194e59f49ec83
parent8ab8c6e6607a14ebd54319535b17e384d2872df9
staging: android: ashmem: fix a race condition in ASHMEM_SET_SIZE ioctl

commit 443064cb0b1fb4569fe0a71209da7625129fb760 upstream.

A lock-unlock is missing in ASHMEM_SET_SIZE ioctl which can result in a
race condition when mmap is called. After the !asma->file check, before
setting asma->size, asma->file can be set in mmap. That would result in
having different asma->size than the mapped memory size. Combined with
ASHMEM_UNPIN ioctl and shrinker invocation, this can result in memory
corruption.

Signed-off-by: Viktor Slavkovic <viktors@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ashmem.c