USB: serial: qcserial: fix altsetting probing
authorJohan Hovold <johan@kernel.org>
Tue, 29 Sep 2020 10:42:39 +0000 (12:42 +0200)
committerJohan Hovold <johan@kernel.org>
Thu, 1 Oct 2020 07:37:30 +0000 (09:37 +0200)
commitbe4c5eb267ee73ef1d70c25c6d648625e96eb477
tree1e7accf37cd9cf4a200a612b977402d592056b39
parent75240ac439eafde7e5b94107ece32b11a334d985
USB: serial: qcserial: fix altsetting probing

Drivers should not assume that interface descriptors have been parsed in
any particular order so use the interface number to look up the second
alternate setting. That number is also what the driver later use to
switch setting.

Note that although the driver could end up verifying the existence of
the expected endpoints on the wrong interface, a later sanity check in
usb_wwan_port_probe() would have caught this before it could cause any
real damage.

Fixes: a78b42824dd7 ("USB: serial: add qualcomm wireless modem driver")
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/qcserial.c