drm/msm: Fix 0xfffflub in "Refactor address space initialization"
authorJohn Stultz <john.stultz@linaro.org>
Sat, 13 Jun 2020 04:21:59 +0000 (04:21 +0000)
committerRob Clark <robdclark@chromium.org>
Sat, 13 Jun 2020 04:59:11 +0000 (21:59 -0700)
commitbc8bd54ffd8513e05eb87b5badcb2d586ea278f0
treef49024bd97baeb129ea2fd557aa873a4a7ce2778
parent2e7ec6b5297157efabb50e5f82adc628cf90296c
drm/msm: Fix 0xfffflub in "Refactor address space initialization"

This week I started seeing GPU crashes on my DragonBoard 845c
which I narrowed down to being caused by commit ccac7ce373c1
("drm/msm: Refactor address space initialization").

Looking through the patch, Jordan and I couldn't find anything
obviously wrong, so I ended up breaking that change up into a
number of smaller logical steps so I could figure out which part
was causing the trouble.

Ends up, visually counting 'f's is hard, esp across a number
of lines:
  0xfffffff != 0xffffffff

This patch corrects the end value we pass in to
msm_gem_address_space_create() in
adreno_iommu_create_address_space() so that it matches the value
used before the problematic patch landed.

With this change, I no longer see the GPU crashes that were
affecting me.

Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Jordan Crouse <jcrouse@codeaurora.org>
Cc: freedreno@lists.freedesktop.org
Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization")
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/adreno_gpu.c