hwmon: (ibmaem) Replace zero-length array with flexible-array member
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 11 Feb 2020 23:42:37 +0000 (17:42 -0600)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 9 Mar 2020 03:35:46 +0000 (20:35 -0700)
commitafde6416e196363e49b85bb129b4c530c9d1b046
treefcde14a24110313b8f0be2394175be9c0b0c648e
parent4d52b28ddfaede27e62abe10d7ce1a6803a1334d
hwmon: (ibmaem) Replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20200211234237.GA26971@embeddedor
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ibmaem.c